Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add To/From CBOR instances for AlonzoGenesis #2294

Merged
merged 1 commit into from
May 19, 2021

Conversation

nc6
Copy link
Contributor

@nc6 nc6 commented May 19, 2021

This is needed since it forms part of the extended ledger state, and is
transmitted to clients (since it's needed to cross the hard fork
boundary). It's not stored in the normal ledger state, nor transmitted
on chain, so we don't care overmuch about the exact serialisation.

This is needed since it forms part of the extended ledger state, and is
transmitted to clients (since it's needed to cross the hard fork
boundary). It's not stored in the normal ledger state, nor transmitted
on chain, so we don't care overmuch about the exact serialisation.
@nc6 nc6 requested a review from newhoggy May 19, 2021 08:54
@nc6
Copy link
Contributor Author

nc6 commented May 19, 2021

At the moment I haven't added this to ShelleyBasedEra, since it would mean moving a bunch of things around. We can add it to the consensus version of that same constraint, which should be just as useful from a node perspective.

Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nc6 nc6 merged commit 6fb462c into master May 19, 2021
@iohk-bors iohk-bors bot deleted the nc/serialise-translateContext branch May 19, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants