Fix mempool #2305
Merged
Fix mempool #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `constructValidated` was validating a Tx according to `UTXOS` semantics. Unfortunately, `UTXOS` is not at the top of the Tx validation hierarchy, which means that checks in `LEDGER`, `UTXO` and `UTXOW` were being ignored. Whoops. This allowed unusual things like repeated transactions being allowed. Subsequently transactions were being rejected when included in the block and kicked out of the mempool without taking effect. This commit changes 'constructValidated' to only set the `IsValidating` flag, and updates the Mempool API to run this validated Tx through the full `LEDGER` rule.
Now that we run the newly constructed (via 'constructValidated') 'ValidatedTx' through the full LEDGER ruleset, we wish to avoid re-evaluating scripts to check the tag which we have just created. This commit achieves that by applying a special label to the 2-phase script validation check, and disabling that check only when processing the LEDGER rules in 'applyTx'.
JaredCorduan
approved these changes
May 27, 2021
iohk-bors bot
added a commit
to IntersectMBO/ouroboros-network
that referenced
this pull request
May 28, 2021
3191: Update cardano-ledger-specs dependency for ledger bugfix r=nc6 a=nfrisby Single commit, see message. Specifically, this brings in Merged PR IntersectMBO/cardano-ledger#2305 Co-authored-by: Nicolas Frisby <nick.frisby@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
constructValidatedwas validating a Tx according toUTXOSsemantics. Unfortunately,
UTXOSis not at the top of the Tx validationhierarchy, which means that checks in
LEDGER,UTXOandUTXOWwerebeing ignored. Whoops. This allowed unusual things like repeated
transactions being allowed. Subsequently transactions were being
rejected when included in the block and kicked out of the mempool
without taking effect.
This commit changes 'constructValidated' to only set the
IsValidatingflag, and updates the Mempool API to run this validated Tx through the
full
LEDGERrule.