Fix Plutus script encoding #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whole point of exposing a CBOR version was so we didn't expose the internal format (which happens to be Flat right now). This was my mistake since I did the wrong thing in the API module. I've fixed that upstream and made sure that there's only one serialization typeclass instance so we don't make this mistake again. Nothing changes in the ledger proper since it already treated scripts as opaque bytestrings, but some tests needed fixing.
michaelpj
force-pushed
the
mpj/fix-script-encoding
branch
from
db6e255
to
30a8caf
Compare
redxaxder
approved these changes
Jun 11, 2021
dcoutts
approved these changes
Jun 11, 2021
|
bors merge |
JaredCorduan
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole point of exposing a CBOR version was so we didn't expose the
internal format (which happens to be Flat right now). This was my
mistake since I did the wrong thing in the API module. I've fixed that
upstream and made sure that there's only one serialization typeclass
instance so we don't make this mistake again.
Nothing changes in the ledger proper since it already treated scripts as
opaque bytestrings, but some tests needed fixing.
(This sha is the tip of the PR I made in Plutus, that PR is based off the old sha. So this is the minimal possible change, and thus avoids us having to deal with the issues Sjoerd is having with master in #2325)