Several small spec changes for audits #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 16, 2021 16:09
(to match the code) See github issue #2122
We also remove the non-integral section, which is no longer needed. The only remaing non-integral computation is the one used in the leader check, but there is still a section for that calculation.
for the variables of type PPUpdateState, to be consistent with the code See github issue #2122
rename moveRewards -> credCoinMap use union override left and swap arguments See github issue #2131
The reward mapping does not have keys that are wrapped in the stake address constructor. See github issue #2174
This was referenced Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing:
#2122 - renaming
depositstodepositedto match code, renamingupsandpupsinUTxOStatetoppupto match code.#2131 - rename
moveRewards->credCoinMap, use union override left and swap arguments to match code#2174 -
stakeDistrtypo with stake address (reward mapping keys are not inside the stake address constructor)Also, I found and fix something else that I found in the processes:
edit: and another one - allow the pool influence parameter (a0) to be zero.