Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canonical creation of WitnessPPdata #2357

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Canonical creation of WitnessPPdata #2357

merged 1 commit into from
Jul 9, 2021

Conversation

redxaxder
Copy link
Contributor

  • Removed annotations from LangDepView, since these are intermediate
    values which are never transmitted/decoded.
  • Changed LangDepView representation to a pair of ByteStrings.
  • Test for canonicity of encoded lang dep view.
  • Added explanation of WitnessPPData data hash to CDDL.

@redxaxder
Copy link
Contributor Author

The definition of LangDepView here differs from the one in the spec, which says the LangDepView is a subset of the protocol parameters.
The previous definition also differed, because the spec asks for something which is hard for us to represent in haskell. This one is a more drastic departure.

@redxaxder redxaxder marked this pull request as draft June 25, 2021 20:05
@redxaxder redxaxder requested a review from WhatisRT June 28, 2021 13:24
@redxaxder redxaxder marked this pull request as ready for review July 6, 2021 15:08
@redxaxder redxaxder force-pushed the redxaxder/witnessppspec branch 2 times, most recently from 791c21f to ca6e140 Compare July 9, 2021 17:49
@redxaxder
Canonical creation of WitnessPPdata
dacec8b 
- Removed annotations from LangDepView, since these are intermediate
  values which are never transmitted/decoded.
- Changed LangDepView representation to a pair of ByteStrings.
- Test for canonicity of encoded lang dep view.
- Added explanation of WitnessPPData data hash to CDDL.

ormolu
@redxaxder redxaxder merged commit 1142663 into master Jul 9, 2021
@iohk-bors iohk-bors bot deleted the redxaxder/witnessppspec branch July 9, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nc6 nc6 nc6 left review comments

@WhatisRT WhatisRT WhatisRT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@redxaxder @WhatisRT @nc6