Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim down deps on Plutus #2372

Merged
merged 3 commits into from
Jul 9, 2021
Merged

Slim down deps on Plutus #2372

merged 3 commits into from
Jul 9, 2021

Conversation

michaelpj
Copy link
Contributor

  • Avoid a few needless deps on plutus-tx, keep all libraries in the main path depending only on plutus-ledger-api.
  • Only import Plutus.Ledger.V1.Api and Plutus.Ledger.V1.Examples.
  • Bump plutus to make the second change possible.

I'll probably follow this up with a change to make those two modules the only exposed modules in plutus-ledger-api, but this is a prerequisite for that.

Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @michaelpj !

@michaelpj
Copy link
Contributor Author

Seems to be confused: the evaluation did pass, and the required job succeeded. I could force-push a new commit, but maybe one of you is an admin and can just merge it?

@michaelpj
Copy link
Contributor Author

Eh, I just force-pushed.

@michaelpj michaelpj merged commit 1eb1ad4 into master Jul 9, 2021
@iohk-bors iohk-bors bot deleted the mpj/slim-plutus-deps branch July 9, 2021 09:34
@JaredCorduan
Copy link
Contributor

sorry Michael, I was confused by what I was seeing in CI as well. I tried re-running the tests twice, but it didn't seem to help. glad the force push worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants