Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ex unit evaluation #2380

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Conversation

redxaxder
Copy link
Contributor

  • round trip test for translating exunits to/from plutus
  • determining whether evaluateTransactionExecutionUnits
    provides enough exUnits

@redxaxder redxaxder changed the title tests fix ex unit evaluation Jul 13, 2021
@redxaxder redxaxder force-pushed the redxaxder/evaluateTransactionExecutionUnits branch from 640711e to 182f5b7 Compare July 13, 2021 17:45
@redxaxder redxaxder marked this pull request as ready for review July 13, 2021 17:45
@redxaxder redxaxder force-pushed the redxaxder/evaluateTransactionExecutionUnits branch from 182f5b7 to 13157f7 Compare July 13, 2021 17:51
@redxaxder redxaxder requested a review from nc6 July 13, 2021 17:52
  - round trip test for translating exunits to/from plutus
  - test whether evaluateTransactionExecutionUnits provides enough exUnits
  - fixed ex unit translation
@redxaxder redxaxder force-pushed the redxaxder/evaluateTransactionExecutionUnits branch from 13157f7 to e07983b Compare July 13, 2021 17:54
@redxaxder redxaxder force-pushed the redxaxder/evaluateTransactionExecutionUnits branch from 41cad68 to d66edb5 Compare July 16, 2021 13:25
scr
datums
evalWithTightBudget :: ShortByteString -> [P.Data] -> Either P.EvaluationError ()
evalWithTightBudget scr datums = do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better, thank you!

Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the tests better and adding new tests!

base16-bytestring,
bytestring,
cardano-binary,
cardano-ledger-alonzo,
cardano-ledger-alonzo-test,
cardano-ledger-shelley-ma,
cardano-ledger-core,
cardano-ledger-test,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be a bit confusing, since I think that package will ultimately want to depend on this one

@nc6 nc6 merged commit 67a478a into master Jul 23, 2021
@iohk-bors iohk-bors bot deleted the redxaxder/evaluateTransactionExecutionUnits branch July 23, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants