rename IsValidating to IsValid #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nc6
approved these changes
Jul 27, 2021
|
|
||
| {-# DEPRECATED isValidating "Use isValid instead" #-} | ||
| isValidating :: ValidatedTx era -> IsValid | ||
| isValidating = isValid |
There was a problem hiding this comment.
For completeness we should also have a deprecated HasField instance.
There was a problem hiding this comment.
great catch, thank you!
There was a problem hiding this comment.
@nc6 is it possible to deprecate a class instance? It doesn't seem like it to me. I can add the instance, and leave a TODO to remove it when we remove the other deprecated functions.
JaredCorduan
force-pushed
the
jc/rename-isvalidating-to-isvalid
branch
from
12f33c1
to
e8e63bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.