Expose event logging downstream #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goolord
reviewed
Aug 2, 2021
| @@ -253,6 +256,15 @@ type family EventReturnType ep sts a :: Type where | |||
| EventReturnType 'EventPolicyReturn sts a = (a, [Event sts]) | |||
| EventReturnType _ _ a = a | |||
|
|
|||
| class EventReturnTypeRep ert where | |||
There was a problem hiding this comment.
maybe EventReturnTypeRep -> ReifyEventPolicy or something
There was a problem hiding this comment.
I went for consistency with RuleTypeRep, in the same file.
lehins
reviewed
Aug 2, 2021
- Generalise `applySTSOptsEither` to all return types. - Add an ability to map over arbitrary return types.
We do not introduce 'reapplyBlockOpts' since this already is a customised version of 'applyBlockOpts'. We also do not currently expose a mempool interface that allows event logging.
JaredCorduan
approved these changes
Aug 2, 2021
There was a problem hiding this comment.
Thank you @nc6 , this looks great!
If I understand correctly, @DavidEichmann can now use applyBlockOpts with the right EventReturnTypeRep to make a version of foldBlocks that can be used to make a client that receives all the blocks, txs, together with the events. yea?
|
Yep, that's the idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the event logging mechanism for use downstream, as well as making some slight changes to its interface.
No changes should be visible to clients using the existing interfaces.