Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small formal spec things #2418

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Small formal spec things #2418

merged 1 commit into from
Sep 3, 2021

Conversation

polinavino
Copy link
Contributor

  • rename wppHash to scriptIntegrityHash and change its calculation to match the code
  • add corollary saying that if the collateral percent parameter is greater than 100, the transaction always pays at least the minfee
  • change Prices from Integer to Rational

WhatisRT
WhatisRT suggested changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@WhatisRT WhatisRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type WitnessPPDataHash and the function hashWitnessPPData also need to be renamed

alonzo/formal-spec/transactions.tex Show resolved Hide resolved
alonzo/formal-spec/protocol-parameters.tex Outdated Show resolved Hide resolved
alonzo/formal-spec/protocol-parameters.tex Outdated Show resolved Hide resolved
WhatisRT
WhatisRT reviewed Sep 2, 2021
View reviewed changes
alonzo/formal-spec/protocol-parameters.tex Outdated Show resolved Hide resolved
alonzo/formal-spec/protocol-parameters.tex Outdated Show resolved Hide resolved
alonzo/formal-spec/protocol-parameters.tex Outdated Show resolved Hide resolved
WhatisRT
WhatisRT reviewed Sep 3, 2021
View reviewed changes
Copy link
Contributor

@WhatisRT WhatisRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only remaining thing is spelling out PP now, everything else looks good!

WhatisRT
WhatisRT approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@WhatisRT WhatisRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polinavino polinavino merged commit dd406af into master Sep 3, 2021
@iohk-bors iohk-bors bot deleted the polina/formal-properties branch September 3, 2021 15:26
@polinavino polinavino mentioned this pull request Oct 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WhatisRT WhatisRT WhatisRT approved these changes

@redxaxder redxaxder Awaiting requested review from redxaxder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polinavino @WhatisRT