Fix WitVKey instance for Ord
#2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/fix-witvkey-ord-instance
branch
from
48d43c9
to
1be6c12
Compare
JaredCorduan
reviewed
Aug 9, 2021
lehins
added a commit
that referenced
this pull request
Aug 23, 2021
lehins
added a commit
that referenced
this pull request
Aug 24, 2021
nc6
added a commit
that referenced
this pull request
Aug 24, 2021
…mpatibility-witckey-ord-take-2 Perpetuate Ord bug (which was fixed in #2419) until Alonzo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Ord instance allows breakage of referential transparency because this law doesn't hold:
compare x y == EQ ==> x == yThis PR fixes this problem and adds couple property tests that ensure the fix.
There are also a couple of other minor improvements included in the PR.