Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separating the protocol from the ledger #2445

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Separating the protocol from the ledger #2445

merged 1 commit into from
Sep 9, 2021

Conversation

JaredCorduan
Copy link
Contributor

This noisy 🥁 PR creates an new package cardano-protocol-tpraos and moves the following into it:

  • Block Header and associated types and helper functions
  • Operational Certificate types and helper functions
  • Overlay Schedule support
  • The following rules: PRTCL, OCERT, OVERLAY, Updn

nc6
nc6 approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@nc6 nc6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think we'll need to pull things apart further, to remove the dependency at all. But this certainly looks like a solid first step!

alonzo/impl/cardano-ledger-alonzo.cabal
@@ -61,6 +61,7 @@ library
cardano-ledger-core,
cardano-ledger-shelley-ma,
cardano-prelude,
cardano-protocol-tpraos,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultimately I guess we'd like to drop this dependency.

cardano-protocol-tpraos/src/Cardano/Protocol/TPraos/BHeader.hs Outdated Show resolved Hide resolved
shelley/chain-and-ledger/executable-spec/src/Shelley/Spec/Ledger/STS/Chain.hs Outdated Show resolved Hide resolved
@JaredCorduan
Copy link
Contributor Author

@nc6 do you think now is an okay time to merge this possibly disruptive PR?

@nc6
Copy link
Contributor

nc6 commented Sep 9, 2021

Yep, seems reasonable to me!

@JaredCorduan JaredCorduan merged commit 92915c3 into master Sep 9, 2021
@iohk-bors iohk-bors bot deleted the jc/separate-protocol branch September 9, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nc6 nc6 nc6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaredCorduan @nc6