Alonzo audit #2448
Merged
Alonzo audit #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polinavino
reviewed
Sep 14, 2021
| \nextdef | ||
| & \fun{feesOK} \in \PParams \to \Tx \to \UTxO \to \Bool \\ | ||
| & \fun{feesOK}~\var{pp}~tx~utxo~= \\ | ||
| &~~ \minfee{pp}~{tx} \leq \txfee{txb} \wedge (\fun{txrdmrs}~tx \neq \Nothing \Rightarrow \\ | ||
| &~~~~~~((\forall (a, \wcard, \_) \in \fun{range}~(\fun{collateral}~{txb} \restrictdom \var{utxo}), \fun{paymentHK}~a \in \AddrVKey) \\ | ||
| &~~~~~~((\forall (a, \wcard, \_) \in \fun{range}~(\fun{collateral}~{txb} \restrictdom \var{utxo}), a \in \AddrVKey) \\ | ||
| &~~~~~~\wedge~ \fun{adaOnly}~\var{balance} \\ | ||
| &~~~~~~\wedge~ \var{balance}~*~100 \geq \txfee~{txb} * (\fun{collateralPercent}~pp))) \\ |
There was a problem hiding this comment.
i think this has a couple extra brackets? I'm having a hard time tracking them here hehe
polinavino
reviewed
Sep 14, 2021
| &~~~~~~\wedge~ \fun{adaOnly}~\var{balance} \\ | ||
| &~~~~~~\wedge~ \var{balance}~*~100 \geq \txfee~{txb} * (\fun{collateralPercent}~pp))) \\ | ||
| &~~~~~~\wedge~ \fun{collateral}~{tx}~ \neq~\{\} \\ | ||
| &~~~~~~\wedge~ \fun{collateral}~{tx}~ \neq~\{\}) \\ |
There was a problem hiding this comment.
i think this closes the line 21 first bracket?
There was a problem hiding this comment.
Yeah, I think the parentheses are fine
polinavino
reviewed
Sep 14, 2021
| @@ -659,7 +663,7 @@ \subsection{The UTXOS transition system} | |||
| \var{txb}\leteq\txbody{tx} & | |||
| \fun{ininterval}~\var{slot}~(\fun{txvldt}~{tx}) & | |||
| \hldiff{\var{(\wcard, i_f)}\leteq\fun{txvldt}~{tx}} \\~\\ | |||
| \hldiff{\fun{txrdmrs}~\var{tx}\neq \Nothing ~\Rightarrow~ \fun{epochInfoSlotToUTCTime}~\mathsf{epochInfo}~\mathsf{systemTime}~i_f \neq \Nothing} \\ | |||
| \hldiff{\Nothing \notin \{\fun{txrdmrs}~\var{tx}, i_f\} ~\Rightarrow~ \fun{epochInfoSlotToUTCTime}~\mathsf{epochInfo}~\mathsf{systemTime}~i_f \neq \Nothing} \\ | |||
There was a problem hiding this comment.
It's a compact way of saying that both of those aren't Nothing. So this modifies the line to only check the conversion if i_f isn't nothing as well
There was a problem hiding this comment.
right, didnt notice it was \notin ... a set
|
two tiny things (which maybe Im just confused about, looks really good otherwise) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of small changes/additions pointed out by different audits