Support for Plutus V2 (ledger API) #2485

JaredCorduan · 2021-09-16T17:26:48Z

These changes add support for the second version of the Plutus ledger API (which now includes all the redeemers for a transaction inside the Plutus context). Using V2 Plutus scripts will result in a phase-one validation error, however, so long as there is no associated cost model.

Subsequent versions (V3, etc) should be simpler to add:

extend the Language enum and follow the GHC warnings.
for serialization, add a new key in the witness set (see the cddl).

The trace generation and the direct LEDGER property tests are now both using PlutusV2. There is also a unit test to ensure that not having a cost model for PlutusV2 results in a phase-one error.

michaelpj · 2021-09-17T09:38:49Z

Notably missing from this PR is support for per language TxInfo, the information that is passed the Plutus. @michaelpj do you think that all the built in types will change (things like TxOutRef), or just TxInfo?

My plan is to re-export the exact same types for everything except TxInfo.

michaelpj · 2021-09-21T12:53:30Z

Okay Jared, you should be able to try this again with plutus master.

nc6

Few suggested changes, otherwise looks good!

eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Data.hs

nc6 · 2021-09-28T07:38:09Z

eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Data.hs

-        (Foldable.toList allScripts)
+    sortScripts (ts, v1, v2) s@(TimelockScript _) = (s : ts, v1, v2)
+    sortScripts (ts, v1, v2) s@(PlutusScript PlutusV1 _) = (ts, s : v1, v2)
+    sortScripts (ts, v1, v2) s@(PlutusScript PlutusV2 _) = (ts, v1, s : v2)


Is there a strong reason to serialise plutus scripts in segregated blocks in this way? I just imagine this will get tiresome when we add even more versions.

I believe this was the original plan all along, but indeed this code is a bit messy, it wasn't pleasant to write...

I'm open to other ideas, but this change does need to be backwards compatible, and we do not currently have the language version in the script serialization.

eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Language.hs

nc6 · 2021-09-28T07:41:58Z

eras/alonzo/impl/src/Cardano/Ledger/Alonzo/PParams.hs

+getLanguageView pp lang@PlutusV2 =
+  LangDepView
+    (serialize' lang)
+    (serializeEncoding' $ maybe encodeNull toCBOR $ Map.lookup lang (_costmdls pp))


Do we expect this implementation to change?

I did not think we could assume that every language view would contain the same data. And I wanted to make sure that GHC would at least make us think about each new language.

nc6 · 2021-09-28T10:42:07Z

eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Tools.hs

@@ -47,7 +56,7 @@ data ScriptFailure c
  | -- | Missing datum.
    MissingDatum (DataHash c)
  | -- | Plutus evaluation error.
-    ValidationFailed P.EvaluationError
+    ValidationFailed PV1.EvaluationError [Text]


This is rather confusing - what happens to Plutus V2 evaluation errors? I guess the key is that presently these types are the same, but it would be good to clarify this at least in the documentation.

If we're going to make it very mechanical, then I think we should have different errors here. Or an error GADT indexed by the language enum?

good catch!

nc6 · 2021-09-28T10:50:50Z

libs/plutus-preprocessor/src/Main.hs

@@ -12,6 +12,7 @@
 --     cd into the plutus-preprocessor directory and type 'cabal run'
 module Main where

+import Cardano.Ledger.Alonzo.Language (Language (..))


I wonder whether this should live elsewhere. But seems reasonable for now!

michaelpj · 2021-09-28T11:06:15Z

eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Scripts.hs

@@ -112,12 +113,12 @@ instance NoThunks Tag
 -- | Scripts in the Alonzo Era, Either a Timelock script or a Plutus script.
 data Script era
  = TimelockScript (Timelock (Crypto era))
-  | PlutusScript ShortByteString -- A Plutus.V1.Ledger.Scripts(Script) that has been 'CBOR' encoded
+  | PlutusScript Language ShortByteString


Hum. I guess I would have expected either:

data Script = TimelockScript ... | PlutusV1Script ... | PlutusV2Script ...

or

data Script = AScript Language ....

or maybe even

data Script = TimeLockScript ... | NonNativeScript Language ...

IDK, there seems like there's maybe still a bit too much "plutus" specificity (if we're trying to be a bit more agnostic about what languages there are).

I was going to cross that bridge when we got there, I don't really know how to anticipate what shape other languages will have.

That said, I'm open to suggestions if you have a favorite!

eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Scripts.hs

michaelpj · 2021-09-28T11:10:58Z

eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Scripts.hs

@@ -294,7 +303,8 @@ instance forall era. (Typeable (Crypto era), Typeable era) => ToCBOR (Script era

 encodeScript :: (Typeable (Crypto era)) => Script era -> Encode 'Open (Script era)
 encodeScript (TimelockScript i) = Sum TimelockScript 0 !> To i
-encodeScript (PlutusScript s) = Sum PlutusScript 1 !> To s -- Use the ToCBOR instance of ShortByteString
+encodeScript (PlutusScript PlutusV1 s) = Sum (PlutusScript PlutusV1) 1 !> To s -- Use the ToCBOR instance of ShortByteString


huh, I guess I would have expected this to use the ToCBOR instance for Language...

I know, it's a bit awkward. See https://github.com/input-output-hk/cardano-ledger-specs/pull/2485/files#r717306756

michaelpj

I have no idea what I'm talking about, feel free to ignore me.

Comments addressed!

kk-hainq · 2021-10-08T15:54:59Z

eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Scripts.hs

  }
  deriving (Eq, Generic, Show)
  -- It is deliberate that there is no Ord instance, use `pointWiseExUnits` instead.
  deriving
-    (BoundedMeasure, Measure)


@JaredCorduan May I ask why was this removed? AlonzoMeasure in ouroboros-network wants it:
https://github.com/input-output-hk/ouroboros-network/blob/e0ccbb73296027a5e5fd224a78374321974758ce/ouroboros-consensus-shelley/src/Ouroboros/Consensus/Shelley/Ledger/Mempool.hs#L314

We were waffling about how best to make this instance, so to move this PR along I removed the instance. This PR adds it back in, with one proposed solution: #2515

Awesome, thank you for the reference!

JaredCorduan requested review from nc6 and redxaxder September 16, 2021 17:26

JaredCorduan force-pushed the jc/multiple-plutus-versions branch 3 times, most recently from 53507a0 to da6389f Compare September 17, 2021 17:15

JaredCorduan mentioned this pull request Sep 23, 2021

Skeleton of passing redeemers in TxInfo #2443

Closed

JaredCorduan force-pushed the jc/multiple-plutus-versions branch from da6389f to aa62640 Compare September 27, 2021 20:29

JaredCorduan marked this pull request as ready for review September 27, 2021 20:30

JaredCorduan force-pushed the jc/multiple-plutus-versions branch from aa62640 to 107b664 Compare September 27, 2021 20:46

JaredCorduan changed the title ~~Draft: Support for more than one version of Plutus~~ Support for more than one version of Plutus Sep 27, 2021

JaredCorduan changed the title ~~Support for more than one version of Plutus~~ Support for Plutus V2 (ledger API) Sep 27, 2021

JaredCorduan force-pushed the jc/multiple-plutus-versions branch 2 times, most recently from 4ae834b to 43f4e3f Compare September 27, 2021 23:14

nc6 previously requested changes Sep 28, 2021

View reviewed changes

michaelpj reviewed Sep 28, 2021

View reviewed changes

eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Scripts.hs Outdated Show resolved Hide resolved

michaelpj reviewed Sep 28, 2021

View reviewed changes

michaelpj approved these changes Sep 28, 2021

View reviewed changes

JaredCorduan force-pushed the jc/multiple-plutus-versions branch from 43f4e3f to 2946ff8 Compare September 29, 2021 01:26

Support PlutusV2

781e2c0

JaredCorduan force-pushed the jc/multiple-plutus-versions branch from 2946ff8 to 781e2c0 Compare October 7, 2021 20:18

JaredCorduan merged commit 8ef01f2 into master Oct 7, 2021

iohk-bors bot deleted the jc/multiple-plutus-versions branch October 7, 2021 21:18

kk-hainq mentioned this pull request Oct 8, 2021

Redeemers in Script Context IntersectMBO/plutus#3844

Closed

kk-hainq reviewed Oct 8, 2021

View reviewed changes

kk-hainq mentioned this pull request Nov 15, 2021

Support Plutus v2 IntersectMBO/plutus-apps#110

Closed

8 tasks

JaredCorduan mentioned this pull request Jan 3, 2022

Use evaluateScriptRestricting instead of evaluateScriptCounting #2490

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for Plutus V2 (ledger API) #2485

Support for Plutus V2 (ledger API) #2485

JaredCorduan commented Sep 16, 2021 •

edited

Loading

michaelpj commented Sep 17, 2021

michaelpj commented Sep 21, 2021

nc6 left a comment

nc6 Sep 28, 2021

JaredCorduan Sep 28, 2021

nc6 Sep 28, 2021

JaredCorduan Sep 28, 2021

nc6 Sep 28, 2021

michaelpj Sep 28, 2021

JaredCorduan Sep 28, 2021

nc6 Sep 28, 2021

michaelpj Sep 28, 2021

JaredCorduan Sep 28, 2021

JaredCorduan Sep 28, 2021

michaelpj Sep 28, 2021

JaredCorduan Sep 28, 2021

michaelpj left a comment

kk-hainq Oct 8, 2021

JaredCorduan Oct 9, 2021 •

edited

Loading

kk-hainq Oct 9, 2021

Support for Plutus V2 (ledger API) #2485

Support for Plutus V2 (ledger API) #2485

Conversation

JaredCorduan commented Sep 16, 2021 • edited Loading

michaelpj commented Sep 17, 2021

michaelpj commented Sep 21, 2021

nc6 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michaelpj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JaredCorduan Oct 9, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JaredCorduan commented Sep 16, 2021 •

edited

Loading

JaredCorduan Oct 9, 2021 •

edited

Loading