replace block header with block header view where appropriate #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
force-pushed
the
jc/blockheader-view
branch
2 times, most recently
from
3d70666
to
7ecb39c
Compare
nc6
approved these changes
Oct 5, 2021
| import Cardano.Ledger.Slot (SlotNo (..), (-*)) | ||
| import Numeric.Natural (Natural) | ||
|
|
||
| data BHeaderView crypto = BHeaderView |
There was a problem hiding this comment.
I think it would be helpful to add some explanatory documentation here!
There was a problem hiding this comment.
yes indeed, thanks!
|
Seems like the answer to that question is "not yet". |
yea, but we are getting closer! I'll have a follow up PR that will parameterize the |
in the BBODY rule
JaredCorduan
force-pushed
the
jc/blockheader-view
branch
from
7ecb39c
to
3e7d8d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new type
BHeaderViewhas been added tocardano-ledger-core, it contains the information from the block header that theBBODYrule needs. The functionisOverlaySlothas also been moved next to theBHeaderViewdefinition (it would be nice to move it tocardano-protocol-tpraos, but it is still needed in theBBODYrule).The BBODY rule no longer takes a
Blockas a signal, but a pair of aBHeaderViewand aTxSeq. Additionally, theapplyBlockAPI function now uses theBHeaderViewas well. Thecardano-protocol-tpraospackage provides a translation from transitional-praos block headers to the view.closes #2460