Ledger API function for stake distribution and pool parameters query #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce and export types `RewardParams` and `RewardInfoPool` * The `getRewardInfoPools` function is essentially a refactoring of the `getNonMyopicMemberRewards` function. * Also reorder the functions in the file and export list more thematically.
and `RewardInfoPool`
JaredCorduan
approved these changes
Oct 6, 2021
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/CAD-3480
branch
from
e652501
to
a1ac597
Compare
nc6
requested changes
Oct 11, 2021
| -- Stake pools and pool rewards | ||
| -------------------------------------------------------------------------------- | ||
|
|
||
| -- | Get the /current/ registered stake pool parameters for a given set of |
There was a problem hiding this comment.
Oops, sorry.
Co-authored-by: Nicholas Clarke <nicholas.clarke@iohk.io>
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/CAD-3480
branch
2 times, most recently
from
4e40729
to
2a20edb
Compare
nc6
approved these changes
Oct 11, 2021
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/CAD-3480
branch
from
2a20edb
to
2f37bf0
Compare
|
[CAD-3480] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
CAD-3480
Summary
module
Cardano.Ledger.Shelley.API.Wallet:RewardParamsandRewardInfoPoolgetRewardInfoPoolsfunction is essentially a refactoring of thegetNonMyopicMemberRewardsfunction.Comments
Exporting
getRewardInfoPoolshelps the wallet to calculate reward predictions (e.g. stake pool desirability, non-myopic rewards, but also future reward measures) for stake pools. It's intended to become a local state query in the node.I have made a best effort to conform with the coding conventions in the ledger, but I'm probably off. I did not know where to put the types. Also, I did not know whether or how to write unit tests (though it seems that the old
GetRewardProvenancedoes not have many tests either.)