at PV 7 make MissingScriptWitnessesUTXOW clearer #2527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
approved these changes
Oct 21, 2021
The MissingScriptWitnessesUTXOW failure is confusing, it reports an empty set in the case of unnecessary scripts. Starting at major protocol version 7, we use a new failure, UnnecessaryScriptWitnessesUTXOW in this case.
JaredCorduan
force-pushed
the
jc/missing-scripts-symmetric-difference
branch
from
6424657 to
284e679
Compare
lehins
reviewed
Oct 21, 2021
Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MissingScriptWitnessesUTXOWfailure is confusing, it reports an empty set in the case of extraneous scripts. Starting at major protocol version 7, we use a new failure,ExtraneousScriptWitnessesUTXOWfor the other side of the symmetric difference.