only store the go snapshot in the reward pulser #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reward pulser is currently storing all three snapshots. It only needs to store the
gostapshot and the fees, so this PR makes the adjustment.Note that this is a change to the ledger state serialization (causing nodes to have to replay from genesis after upgrading). I think it is worth it, though. Though sharing might usually mean no extra memory is used, if a node is shut down and brought back up while the pulser is pulsing, the sharing is lost. In practice this means that if Deadalus is started up on day three of an epoch, it is holding in memory two stake distributions and two delegation mappings that it doesn't need to.