Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshots with array base map #2540

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Snapshots with array base map #2540

merged 1 commit into from
Nov 10, 2021

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Nov 5, 2021

Implement Vector based map for snapshots to save memory

@lehins lehins requested a review from TimSheard as a code owner November 5, 2021 15:03
JaredCorduan
JaredCorduan approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I only had a few trivial suggestions and questions.

eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/Examples/TwoPools.hs Show resolved Hide resolved
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/Serialisation/Golden/Encoding.hs Show resolved Hide resolved
libs/cardano-ledger-core/src/Cardano/Ledger/Coin.hs Outdated Show resolved Hide resolved
libs/ledger-state/bench/Memory.hs Show resolved Hide resolved
libs/small-steps/src/Data/Coders.hs Outdated Show resolved Hide resolved
@lehins lehins force-pushed the lehins/snapshots-with-arrays branch from 5676bde to 2a36234 Compare November 8, 2021 18:40
@lehins
Implement vector base VMap and use it in SnapShot.
a2186a3 
* Add a memory benchmark using vector based KeyValue for SnapShots:

```
  Case                                     Max          MaxOS         Live        Allocated      GCs  Wall Time
  SnapShots (VMap) - no sharing    546,563,824  1,026,555,904  546,563,824  184,981,577,080  178,027   182.227s
  SnapShots (VMap) - with sharing  239,352,936    397,410,304  239,352,936  185,324,724,496  178,405   197.413s
  SnapShots (Map) - no sharing     725,778,768  1,474,297,856  725,778,768  185,325,603,672  178,485   183.096s
  SnapShots (Map) - with sharing   418,567,928    851,443,712  418,567,928  184,207,105,776  177,339   179.746s
```
@lehins lehins force-pushed the lehins/snapshots-with-arrays branch from 4eda640 to a2186a3 Compare November 9, 2021 21:42
@lehins lehins merged commit d3d6d07 into master Nov 10, 2021
@iohk-bors iohk-bors bot deleted the lehins/snapshots-with-arrays branch November 10, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@TimSheard TimSheard Awaiting requested review from TimSheard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lehins @JaredCorduan