Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new datatype to replace UTxO currently a Data.Map #2567

Merged
merged 4 commits into from
Dec 8, 2021

Conversation

TimSheard
Copy link
Contributor

Introduces the SplitMap. Added basic operations for SplitMap that
every Map should supply (insert, delete, union, intersection etc).
Added Basic and Iter instances for Control.SetAlgebra.

@TimSheard TimSheard force-pushed the ts-new-utxo branch 2 times, most recently from 53b04dd to e4f6111 Compare December 3, 2021 18:29
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor syntactic suggestions and one performance improvement suggestion. Otherwise looks great!

libs/compact-map/src/Data/Compact/SplitMap.hs Outdated Show resolved Hide resolved
libs/compact-map/src/Data/Compact/SplitMap.hs Outdated Show resolved Hide resolved
libs/compact-map/src/Data/Compact/SplitMap.hs Outdated Show resolved Hide resolved
libs/compact-map/src/Data/Compact/SplitMap.hs Outdated Show resolved Hide resolved
libs/compact-map/src/Data/Compact/SplitMap.hs Show resolved Hide resolved
Introduces the SplitMap. Added basic operations for SplitMap that
every Map should supply (insert, delete, union, intersection etc).
Added Basic and Iter instances for Control.SetAlgebra.
Added the function rewite that applies SplitMap specific rules.
Added tests that every rewrite that applies, has the same answer
in the fast mode (using the rewrite) and the slow mode (using
the Iterator instances).
@lehins lehins changed the title WIP Adding a new datatype to replace UTxO currently a Data.Map Adding a new datatype to replace UTxO currently a Data.Map Dec 7, 2021
@lehins lehins merged commit fdcb83f into master Dec 8, 2021
@iohk-bors iohk-bors bot deleted the ts-new-utxo branch December 8, 2021 16:00
@lehins lehins mentioned this pull request Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants