-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a new datatype to replace UTxO currently a Data.Map #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimSheard
force-pushed
the
ts-new-utxo
branch
2 times, most recently
from
December 3, 2021 18:29
53b04dd
to
e4f6111
Compare
lehins
approved these changes
Dec 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor syntactic suggestions and one performance improvement suggestion. Otherwise looks great!
eras/shelley/test-suite/test/Test/Control/Iterate/SplitMapRules.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/test/Test/Control/Iterate/SplitMapRules.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/test/Test/Control/Iterate/SplitMapRules.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/test/Test/Control/Iterate/SplitMapRules.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/test/Test/Control/Iterate/SplitMapRules.hs
Outdated
Show resolved
Hide resolved
Introduces the SplitMap. Added basic operations for SplitMap that every Map should supply (insert, delete, union, intersection etc). Added Basic and Iter instances for Control.SetAlgebra. Added the function rewite that applies SplitMap specific rules. Added tests that every rewrite that applies, has the same answer in the fast mode (using the rewrite) and the slow mode (using the Iterator instances).
TimSheard
force-pushed
the
ts-new-utxo
branch
from
December 7, 2021 01:45
8949038
to
0b487e5
Compare
lehins
changed the title
WIP Adding a new datatype to replace UTxO currently a Data.Map
Adding a new datatype to replace UTxO currently a Data.Map
Dec 7, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the SplitMap. Added basic operations for SplitMap that
every Map should supply (insert, delete, union, intersection etc).
Added Basic and Iter instances for Control.SetAlgebra.