fix errata 17.2 in protocol version 7 #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
commented
Dec 2, 2021
| potentialRewards' = | ||
| if HardForks.forgoRewardPrefilter pp | ||
| then potentialRewards | ||
| else eval (addrsRew ◁ potentialRewards) |
There was a problem hiding this comment.
reassuringly, the tests did not pass without this modification. :)
nc6
requested changes
Dec 3, 2021
namely, no longer prefilter the rewards by those who are currently not registered at the start of the reward calculation.
JaredCorduan
force-pushed
the
jc/fix-shelley-errata-17-2
branch
from
721db7a to
950b83f
Compare
nc6
approved these changes
Dec 6, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namely, no longer prefilter the rewards by those who are currently not registered at the start of the reward calculation. cc @ashisherc
closes #2477