Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update Rust builder, add target flag #140

Merged
merged 50 commits into from
Jan 18, 2024
Merged

feat: Update Rust builder, add target flag #140

merged 50 commits into from
Jan 18, 2024

Conversation

stevenj
Copy link
Collaborator

@stevenj stevenj commented Jan 3, 2024 •
edited by Mr-Leshiy
Loading

Description

Updated rust builder, add new configuration options for building step. Replaced bash scripts with python one.

Related Issue(s)

Part of the input-output-hk/hermes#20

Description of Changes

  • replaced std_build.sh and std_check.sh with Python implementation std_check.py and std_build.py.
  • modified cargo config.toml files, provided new target.wasm32-unknown-unknown compile options, removed --locked flag from all aliases (because we are going to remove Cargo.lock files from the repo), disabled cargo progress bar and disabled verbose.
  • Moved SMOKE_TEST udc functionality to the std_build.py script.
  • removed nushell installation.
  • some other cleanups

@stevenj stevenj added the draft Review only, do not merge yet label Jan 3, 2024
@Mr-Leshiy
Copy link
Contributor

updated docs:
https://input-output-hk.github.io/catalyst-ci/branch/feat_rust_wasm/guides/languages/rust/

@Mr-Leshiy Mr-Leshiy force-pushed the feat/rust-wasm branch 2 times, most recently from e41830e to 4a2bae8 Compare January 15, 2024 10:39
@stevenj stevenj enabled auto-merge (squash) January 18, 2024 04:27
Mr-Leshiy
Mr-Leshiy approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 9b5e173 into master Jan 18, 2024
51 checks passed
@stevenj stevenj deleted the feat/rust-wasm branch January 18, 2024 08:53
This was linked to issues Jan 23, 2024
🛠️ [TASK] : Clean up rust builder logging #142
Closed
🛠️ [TASK] : SMOKE_TEST UDC bin argument handles array #113
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mr-Leshiy Mr-Leshiy Mr-Leshiy approved these changes

@FelipeRosa FelipeRosa Awaiting requested review from FelipeRosa

@saibatizoku saibatizoku Awaiting requested review from saibatizoku

@cong-or cong-or Awaiting requested review from cong-or

@bkioshn bkioshn Awaiting requested review from bkioshn

@minikin minikin Awaiting requested review from minikin

@apskhem apskhem Awaiting requested review from apskhem

Assignees

@Mr-Leshiy Mr-Leshiy

Labels
ci/cd CI/CD Fixes or Improvements. enhancement New feature or request
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Clean up rust builder logging 🛠️ [TASK] : SMOKE_TEST UDC bin argument handles array
2 participants
@stevenj @Mr-Leshiy