Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bottle in the sea]: add grpc message and subscription #311

Open
NicolasDP opened this issue Mar 26, 2020 · 3 comments
Open

[bottle in the sea]: add grpc message and subscription #311

NicolasDP opened this issue Mar 26, 2020 · 3 comments
Assignees

Comments

@NicolasDP
Copy link
Contributor

epic input-output-hk/jormungandr#1972

we need a message and a subscription in order to allow a new class of gossip to be broadcasted through the network.

The content of the message is not specified yet, so a byte array is expected at the moment.

@eugene-babichenko
Copy link
Contributor

Basically, all we need to do on the network side is to define a separate subscription (EncryptedGossipSubscription) and a message type (EncryptedGossip) in the node service. This is a simple way to be backwards compatible with older nodes.

@eugene-babichenko
Copy link
Contributor

@mzabaluev I drafted an implementation of the on the grpc side, can you take a look? 6ac0462

@mzabaluev
Copy link
Contributor

Adding a new subscription stream will bring additional complexity to the code and is not really necessary. We have the protobuf message Gossip as an item of gossip streams. All fields in that message are technically optional. We can add a new field to this message to carry the BITS payloads along with plain old node records.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants