Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateProposal replay #674

Open
zeegomo opened this issue Oct 26, 2021 · 0 comments
Open

UpdateProposal replay #674

zeegomo opened this issue Oct 26, 2021 · 0 comments

Comments

@zeegomo
Copy link
Contributor

zeegomo commented Oct 26, 2021

The current implementation of SignedUpdateProposal leaves some space for replay attacks. If the signature is only on the changes, it can be replayed at a later date, or in a different chain.

I'm not sure of the implications, submitting a transaction still requires to pay some fee, and if the proposal is not any good other leaders would not vote it. On the other side, if the proposal is accepted, that means bft leaders agreed on it.

However, I do not like having an implementation that suggests something is securely authenticated when it's not. I think we should either fix this (e.g. include a counter of how many proposals have been submitted + block0 hash in the signature, have the whole transaction directly signed by a bft leader key?) or remove the signature altogether. I still don't have a strong preference on any of the two, but maybe sticking with the initial idea of only allowing bft leaders to do so is a safer approach.

Originally posted by @zeegomo in #665 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant