Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wasm::Module benchmark #109

Merged
merged 43 commits into from
Feb 27, 2024
Merged

feat: wasm::Module benchmark #109

merged 43 commits into from
Feb 27, 2024

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Feb 5, 2024

Description

Added benchmark for the wasm::Module execution using the criterion lib

Related Issue(s)

Closes #79

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy self-assigned this Feb 5, 2024
@minikin minikin added the draft Draft label Feb 5, 2024
@Mr-Leshiy Mr-Leshiy changed the title feat: Module::call_func benchmark feat: wasm::Module benchmark Feb 13, 2024
@stevenj
Copy link
Collaborator

stevenj commented Feb 22, 2024

I am happy with the benchmarks, and the performance they are measuring. They will give us a yardstick we can use as hermes evolves to help find performance regressions should they occur.

Once this is in a mergable state I am happy to approve it.

@Mr-Leshiy
Copy link
Contributor Author

depends on input-output-hk/catalyst-ci#195

@Mr-Leshiy Mr-Leshiy reopened this Feb 27, 2024
@Mr-Leshiy Mr-Leshiy added review me PR is ready for review and removed do not merge yet PR is not ready to be merged yet comment me Request for comments labels Feb 27, 2024
FelipeRosa
FelipeRosa previously approved these changes Feb 27, 2024
Copy link

@FelipeRosa FelipeRosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a comment but LGTM

hermes/bin/src/wasm/module.rs Outdated Show resolved Hide resolved
@Mr-Leshiy Mr-Leshiy enabled auto-merge (squash) February 27, 2024 13:19
@Mr-Leshiy Mr-Leshiy merged commit f022eb5 into main Feb 27, 2024
21 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/wasm-module-bench branch February 27, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : WASM Module benchmark
5 participants