Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cardano-chain-follower): Merge Reader functions with the Follower #115

Merged
merged 6 commits into from
Feb 9, 2024
Merged

chore(cardano-chain-follower): Merge Reader functions with the Follower #115

merged 6 commits into from
Feb 9, 2024

Conversation

FelipeRosa
Copy link

@FelipeRosa FelipeRosa commented Feb 6, 2024 •
edited
Loading

Description

This PR removes the Reader struct and move its functions to the Follower in cardano-chain-follower.

Related Issue(s)

Closes #68.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@FelipeRosa FelipeRosa self-assigned this Feb 6, 2024
@minikin minikin added the draft Draft label Feb 7, 2024
@FelipeRosa FelipeRosa marked this pull request as ready for review February 9, 2024 13:28
@FelipeRosa FelipeRosa added review me PR is ready for review and removed draft Draft labels Feb 9, 2024
@minikin minikin merged commit d6edf48 into main Feb 9, 2024
28 checks passed
@minikin minikin deleted the chore/merge-reader-follower branch February 9, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minikin minikin minikin approved these changes

@stevenj stevenj Awaiting requested review from stevenj stevenj is a code owner

@Mr-Leshiy Mr-Leshiy Awaiting requested review from Mr-Leshiy Mr-Leshiy is a code owner

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@saibatizoku saibatizoku Awaiting requested review from saibatizoku saibatizoku is a code owner

Assignees

@FelipeRosa FelipeRosa

Labels
review me PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK]: Remove Reader from cardano-chain-follower
2 participants
@FelipeRosa @minikin