Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cbork): Add new cbor kit crates #116

Merged
merged 15 commits into from
Mar 18, 2024
Merged

feat(cbork): Add new cbor kit crates #116

merged 15 commits into from
Mar 18, 2024

Conversation

stevenj
Copy link
Collaborator

@stevenj stevenj commented Feb 6, 2024 •
edited
Loading

Description

CBOR CDDL and ABNF Parsers

Related Issue(s)

Closes #178

Description of Changes

Initial CDDL/ABNF parser libraries for future CDDL tooling requirements

Breaking Changes

None, these crates are currently unused.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

stevenj and others added 4 commits January 4, 2024 16:11
@stevenj
feat(cbork): First cddl parser code
3103ee0
@apskhem
feat: Earthfile to CBORK (#53)
33a01a3 
* feat: earthfile

* feat: add targets in Rust toolchain

* fix: enable cspell and add file specific words instead

* fix: fmtfix

* fix: resolver

* fix: cspell my name

* fix: comment

* fix: add generate-lockfile
@apskhem
feat: CDDL module structure (#55)
99608dc 
* feat: module extension

* refactor: compact return type

* chore: fmtfix

* fix: lint

* fix: function docs comment

* feat: add placeholders

* refactor: compact error mapping

* fix: remove cddl test error type

* fix: postlude test

* fix: move postlude content inside test

* docs: CDDLErrorType

* docs: fix typo

* fix: test print

* feat: placeholder files

* refactor: remove direct type

* chore: fix linting

* fix: return unit instead

* fix: input as &mut String

* chore: fmtfix
@apskhem
feat: CDDL grammar correction for RFC8610 (#61)
efe780a 
* feat: example files

* refactor: rename test files

* refactor: rename from rfc9615 to rfc9165

* feat: error display for testing multiple files

* feat: sort file reading

* fix: whitespace problem for ',', braces, and //

* feat: group elements initial unit test

* fix: comments

* fix: grammar correction for comments

* fix: grammar correcttion according to abnf

* fix: remove genericarg from typename and groupname

* fix: unit tests

* feat: initial group_elements test cases

* fix: put atomic test back

* revert: deleted grammar and tests

* fix: correct test cases

* feat: type decl tests

* feat: type decl tests

* feat: setup type decl test

* feat: type1 test cases

* feat: composition testing

* feat: rules test cases

* feat: rules test cases

* feat: all examples from rfc8610

* feat: add rule level tests

* refactor: use general passes and fails function in unit test

* fix: error msg for cddl

* fix: cddl test file name reading

* fix: cspell

* chore: lintfix

* refactor: cddl filter fn

* refactor: reset

* fix: pub(crate) for unit tests

* chore: fmtfix

* refactor: don't dry util functions

* fix: disable lint warning

* chore: fmtfix

* refactor: change common path

* feat: common

* refactor: remove tmp vars

* feat: common consts

* fix: add tmp allow dead code

* fix: cspell
@stevenj stevenj self-assigned this Feb 6, 2024
@stevenj stevenj added the draft Draft label Feb 6, 2024
@stevenj stevenj marked this pull request as draft February 6, 2024 14:16
@stevenj stevenj changed the title Feat/cbork feat(cbork): Add new cbor kit crates Feb 6, 2024
apskhem and others added 4 commits February 7, 2024 21:32
@apskhem
feat(cbor): Initial ABNF parser (#113)
fc97743 
* feat: initial commit

* feat: initial abnf grammar

* fix: correct abnf grammar

* feat: update abnf test

* feat: integration test init

* fix: update correction on errata

* fix: correct grammar

* fix: grammar on testing

* feat: test modules

* feat: comment tests

* feat: unit tests placeholder

* feat: c_wsp tests

* feat: value tests

* feat: repeat

* fix: restructure groups and elements

* feat: all unit tests

* fix: partial cspell

* fix: cspell

* fix: config files

* ci: update earthly

* docs: parse function

* fix: minor cspell

* docs: cddl ast temp

* docs: fix cddl docs

* docs: add docs to abnf AST and ABNFError

* fix: dead code
@stevenj
Merge branch 'main' into feat/cbork
0893e9b
@stevenj
Merge branch 'main' into feat/cbork
b5022ed
@stevenj
Merge branch 'main' into feat/cbork
f85e99f
@stevenj stevenj marked this pull request as ready for review March 11, 2024 07:19
@stevenj stevenj enabled auto-merge (squash) March 11, 2024 07:21
minikin
minikin previously requested changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs of this size are tricky to review. We need to find a way to make PRs smaller in the future.

hermes/crates/cbork/.config/nextest.toml Outdated Show resolved Hide resolved
@apskhem apskhem requested review from minikin and apskhem March 11, 2024 16:04
saibatizoku
saibatizoku previously approved these changes Mar 12, 2024
View reviewed changes
stevenj
stevenj commented Mar 18, 2024
View reviewed changes
Copy link
Collaborator Author

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See requested changes, and add these words to project words and remove from all cspell comments

hermes/crates/cbork/Cargo.toml Outdated Show resolved Hide resolved
hermes/crates/cbork/Earthfile Outdated Show resolved Hide resolved
hermes/crates/cbork/README.md Outdated Show resolved Hide resolved
hermes/crates/cbork/abnf-parser/Cargo.toml Outdated Show resolved Hide resolved
hermes/crates/cbork/abnf-parser/src/grammar/rfc_5234.pest Outdated Show resolved Hide resolved
hermes/crates/cbork/abnf-parser/tests/testsuite/main.rs Outdated Show resolved Hide resolved
hermes/crates/cbork/abnf-parser/tests/testsuite/repetitions.rs Outdated Show resolved Hide resolved
hermes/crates/cbork/abnf-parser/tests/testsuite/rules.rs Outdated Show resolved Hide resolved
hermes/crates/cbork/abnf-parser/tests/testsuite/values.rs Outdated Show resolved Hide resolved
hermes/crates/cbork/cddl-parser/src/lib.rs Outdated Show resolved Hide resolved
@stevenj stevenj dismissed minikin’s stale review March 18, 2024 11:58

spelling exceptions reduced

minikin
minikin approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 8b2ac7b into main Mar 18, 2024
23 checks passed
@stevenj stevenj deleted the feat/cbork branch March 18, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minikin minikin minikin approved these changes

@Mr-Leshiy Mr-Leshiy Awaiting requested review from Mr-Leshiy Mr-Leshiy is a code owner

@FelipeRosa FelipeRosa Awaiting requested review from FelipeRosa

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@apskhem apskhem Awaiting requested review from apskhem

@saibatizoku saibatizoku Awaiting requested review from saibatizoku saibatizoku is a code owner

Assignees

@stevenj stevenj

Labels
draft Draft
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : CBOR/CDDL/ABNF Parser crates
4 participants
@stevenj @saibatizoku @minikin @apskhem