Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wasm): C stub #118

Merged
merged 27 commits into from
Feb 20, 2024
Merged

feat(wasm): C stub #118

merged 27 commits into from
Feb 20, 2024

Conversation

apskhem
Copy link
Collaborator

@apskhem apskhem commented Feb 7, 2024

Description

Implement all events defined in Hermes .wit file exports in C and prepare a builder to build the wasm module.

Related Issue(s)

Closes #117

Description of Changes

  • Implemented stuff in C that needed to be compiled as stub functions
  • Added an Earthfile for automated compilation into .wasm component

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem added the draft Draft label Feb 7, 2024
@apskhem apskhem self-assigned this Feb 7, 2024
@apskhem apskhem linked an issue Feb 7, 2024 that may be closed by this pull request
@stevenj stevenj marked this pull request as draft February 8, 2024 06:51
@apskhem apskhem changed the title [WIP] feat(wasm): C stub feat(wasm): C stub Feb 16, 2024
@apskhem apskhem marked this pull request as ready for review February 16, 2024 12:04
@apskhem apskhem removed the draft Draft label Feb 16, 2024
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if C has some modern linters/formaters?

wasm/event-stubs/Earthfile Outdated Show resolved Hide resolved
wasm/event-stubs/Earthfile Outdated Show resolved Hide resolved
wasm/event-stubs/Earthfile Outdated Show resolved Hide resolved
@apskhem apskhem added the review me PR is ready for review label Feb 16, 2024
@apskhem
Copy link
Collaborator Author

apskhem commented Feb 16, 2024

I'm wondering if C has some modern linters/formaters?

Currently, we don't have any checks in place. For now, the code just needs to be simple and work. If we decide to add those checks later on, we can update and improve the code at that time.

Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🥳

@minikin minikin enabled auto-merge (squash) February 16, 2024 14:55
wasm/event-stubs/Earthfile Outdated Show resolved Hide resolved
wasm/event-stubs/Earthfile Outdated Show resolved Hide resolved
wasm/event-stubs/my-component.c Outdated Show resolved Hide resolved
wasm/event-stubs/Earthfile Outdated Show resolved Hide resolved
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin merged commit 581ecca into main Feb 20, 2024
9 of 10 checks passed
@minikin minikin deleted the feat/c-stub branch February 20, 2024 09:46
stevenj added a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : C stub wasm module
4 participants