Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Hermes events implementation #126

Merged
merged 12 commits into from
Feb 14, 2024
Merged

feat: Hermes events implementation #126

merged 12 commits into from
Feb 14, 2024

Conversation

Mr-Leshiy
Copy link
Contributor

Description

  • Refactored hermes runtime extensions structure. Split a host functionality for every runtime extensions into the different Rust module
  • Added initial event implementation (implementation of the HermesEventPayload trait) for all the runtime extensions which have it.

@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Feb 14, 2024
@Mr-Leshiy Mr-Leshiy self-assigned this Feb 14, 2024
saibatizoku
saibatizoku previously approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@saibatizoku saibatizoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Mr-Leshiy Mr-Leshiy enabled auto-merge (squash) February 14, 2024 20:31
saibatizoku
saibatizoku approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@saibatizoku saibatizoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy merged commit 6810b31 into main Feb 14, 2024
20 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/hermes-events branch February 14, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saibatizoku saibatizoku saibatizoku approved these changes

@stevenj stevenj Awaiting requested review from stevenj stevenj is a code owner

@FelipeRosa FelipeRosa Awaiting requested review from FelipeRosa

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@minikin minikin Awaiting requested review from minikin minikin is a code owner

Assignees

@Mr-Leshiy Mr-Leshiy

Labels
review me PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mr-Leshiy @saibatizoku