Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bindings-expand Earthly target #136

Merged
merged 8 commits into from
Feb 21, 2024
Merged

feat: bindings-expand Earthly target #136

merged 8 commits into from
Feb 21, 2024

Conversation

Mr-Leshiy
Copy link
Contributor

Description

Added new bindings-expand Earthly target, which expands wasmtime::bindgen! into the separate file

Related Pull Requests

Depends on input-output-hk/catalyst-ci#190

@Mr-Leshiy Mr-Leshiy self-assigned this Feb 19, 2024
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Feb 20, 2024
@Mr-Leshiy Mr-Leshiy marked this pull request as ready for review February 20, 2024 09:43
@minikin minikin enabled auto-merge (squash) February 21, 2024 12:05
Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙌🏼

Copy link
Collaborator

@apskhem apskhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

Copy link

@FelipeRosa FelipeRosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin merged commit c964b27 into main Feb 21, 2024
28 checks passed
@minikin minikin deleted the feat/bindings-expand branch February 21, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants