Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: HRE implementation notes #169

Merged
merged 34 commits into from
Mar 12, 2024
Merged

docs: HRE implementation notes #169

merged 34 commits into from
Mar 12, 2024

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Mar 5, 2024 •
edited
Loading

Description

  • Updated Hermes core of the "Building blocks" section.
  • Added HRE implementation structure notes into the "Concepts" section (previously it was HRE interface).

Updated sections:

@Mr-Leshiy Mr-Leshiy added the draft Draft label Mar 5, 2024
@Mr-Leshiy Mr-Leshiy self-assigned this Mar 5, 2024
@Mr-Leshiy Mr-Leshiy changed the title docs: HRE implementation nots docs: HRE implementation notes Mar 5, 2024
@Mr-Leshiy Mr-Leshiy mentioned this pull request Mar 5, 2024
Open
5 tasks
@Mr-Leshiy Mr-Leshiy added review me PR is ready for review documentation Pull requests that update a dependency file. and removed draft Draft labels Mar 5, 2024
Mr-Leshiy and others added 2 commits March 5, 2024 17:52
@Mr-Leshiy @minikin
Update docs/src/architecture/08_concepts/hermes_runtime_engine/hre_st…
dacbf48 
…ate.md

Co-authored-by: Oleksandr Prokhorenko   <djminikin@gmail.com>
@Mr-Leshiy @minikin
Update docs/src/architecture/08_concepts/hermes_runtime_engine/hre_st…
e555339 
…ructure.md

Co-authored-by: Oleksandr Prokhorenko   <djminikin@gmail.com>
@Mr-Leshiy Mr-Leshiy requested a review from minikin March 5, 2024 16:12
minikin
minikin previously approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy requested a review from minikin March 5, 2024 19:05
bkioshn
bkioshn reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@bkioshn bkioshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, clear and straight to the point. Just some typo 🥳

docs/src/architecture/05_building_block_view/hermes_engine.md Outdated Show resolved Hide resolved
docs/src/architecture/05_building_block_view/hermes_engine.md Outdated Show resolved Hide resolved
docs/src/architecture/08_concepts/hermes_runtime_engine/hre_structure.md Outdated Show resolved Hide resolved
@Mr-Leshiy Mr-Leshiy requested a review from bkioshn March 6, 2024 10:00
stevenj
stevenj requested changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stylistic changes requested mostly

docs/src/architecture/08_concepts/hermes_runtime_engine/hre_structure.md Outdated Show resolved Hide resolved
docs/src/architecture/08_concepts/hermes_runtime_engine/hre_structure.md Outdated Show resolved Hide resolved
docs/src/architecture/08_concepts/hermes_runtime_engine/hre_structure.md Outdated Show resolved Hide resolved
docs/src/architecture/08_concepts/hermes_runtime_engine/hre_structure.md Outdated Show resolved Hide resolved
docs/src/architecture/08_concepts/hermes_runtime_engine/hre_structure.md Outdated Show resolved Hide resolved
docs/src/architecture/08_concepts/hermes_runtime_engine/hre_structure.md Outdated Show resolved Hide resolved
docs/src/architecture/08_concepts/hermes_runtime_engine/hre_structure.md Outdated Show resolved Hide resolved
docs/src/architecture/08_concepts/hermes_runtime_engine/hre_structure.md Outdated Show resolved Hide resolved
docs/src/architecture/08_concepts/hermes_runtime_engine/hre_structure.md Outdated Show resolved Hide resolved
docs/src/architecture/08_concepts/hermes_runtime_engine/hre_structure.md Outdated Show resolved Hide resolved
Mr-Leshiy and others added 9 commits March 7, 2024 11:00
@Mr-Leshiy @stevenj
Update docs/src/architecture/08_concepts/hermes_runtime_engine/hre_st…
4631840 
…ructure.md

Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com>
@Mr-Leshiy @stevenj
Update docs/src/architecture/08_concepts/hermes_runtime_engine/hre_st…
a8808e7 
…ructure.md

Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com>
@Mr-Leshiy @stevenj
Update docs/src/architecture/08_concepts/hermes_runtime_engine/hre_st…
2860cc0 
…ructure.md

Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com>
@Mr-Leshiy @stevenj
Update docs/src/architecture/08_concepts/hermes_runtime_engine/hre_st…
6dd2e47 
…ructure.md

Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com>
@Mr-Leshiy @stevenj
Update docs/src/architecture/08_concepts/hermes_runtime_engine/hre_st…
9e8437a 
…ructure.md

Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com>
@Mr-Leshiy @stevenj
Update docs/src/architecture/08_concepts/hermes_runtime_engine/hre_st…
64824b3 
…ructure.md

Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com>
@Mr-Leshiy @stevenj
Update docs/src/architecture/08_concepts/hermes_runtime_engine/hre_st…
a9ee4ec 
…ructure.md

Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com>
@Mr-Leshiy
include wit files into docs
1299b48
@Mr-Leshiy
fix
068878b
@Mr-Leshiy Mr-Leshiy requested a review from stevenj March 7, 2024 10:54
@stevenj stevenj merged commit 3b93a6b into main Mar 12, 2024
21 checks passed
@stevenj stevenj deleted the feat/hre-implementation branch March 12, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenj stevenj stevenj approved these changes

@saibatizoku saibatizoku Awaiting requested review from saibatizoku

@cong-or cong-or Awaiting requested review from cong-or

@FelipeRosa FelipeRosa Awaiting requested review from FelipeRosa

@apskhem apskhem Awaiting requested review from apskhem

@minikin minikin Awaiting requested review from minikin

@bkioshn bkioshn Awaiting requested review from bkioshn

Assignees

@Mr-Leshiy Mr-Leshiy

Labels
documentation Pull requests that update a dependency file. review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mr-Leshiy @stevenj @minikin @bkioshn