-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: time module #200
Merged
Merged
test: time module #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apskhem
requested review from
stevenj,
Mr-Leshiy,
FelipeRosa,
cong-or,
saibatizoku and
minikin
as code owners
April 5, 2024 10:58
stevenj
requested changes
Apr 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not contain tests for all the time API's as required.
They need to be added.
https://github.com/input-output-hk/hermes/tree/feat/verbose-rust-unit-tests/hermes/bin/src/runtime_extensions/wasi/clocks is also time API's.
stevenj
approved these changes
Apr 8, 2024
stevenj
added a commit
that referenced
this pull request
Apr 9, 2024
* fix(wasm): Fix running wasm integration tests * fix(wasm): Make logging work inside the wasm integration tests * feat(wasm): working hashing integration test * ci(wasm): align rust builds with cat-ci latest version * feat(wasm): Add crypto wasm integration tests * fix(hermes): Re-enable hermes full build after getting wasm integration tests working * fix(wasm): silence the initial print inside wasm integration tests to prevent issues when running * fix(wasm): remove unused import after silencing the wasm integration tester * style(hermes): Fix code format * fix(spelling): spelling issue * fix(cbork): Align deny,toml with CI * fix(wasm): Align deny.toml with CI * Update hermes/bin/src/runtime_extensions/hermes/crypto/host.rs Co-authored-by: bkioshn <35752733+bkioshn@users.noreply.github.com> * Update hermes/bin/src/runtime_extensions/hermes/crypto/host.rs Co-authored-by: bkioshn <35752733+bkioshn@users.noreply.github.com> * feat: hermes-cron integration test cases (#199) * feat(wip): stub hermes-cron integration test cases * feat: add tests for cron api functions * fix: compare returned string with expected * feat(warm): Add Cardano Runtime Extension integration test skeleton (#198) * feat(wasm): Add Cardano Runtime Extension integration tests skeleton * feat(wasm): Use pallas to parse blocks in Cardano RTE integration test component --------- Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com> * fix(wasm): remove commented obsolete code * Update wasm/integration-test/crypto/crypto.c Co-authored-by: bkioshn <35752733+bkioshn@users.noreply.github.com> * test: time module (#200) * feat: initial commit * feat: simple function * ci: add test * test: restructure and add test to localtime * fix: minor format * refactor: remove localtime name * fix: localtime issue * feat: clocks test * fix: test warms * fix: use existing tests * chore: earthfile tmp * fix: builder * fix: remove wall test * chore: fmtfix * fix(spelling): add to project words * fix(wasm): remove generated bindings, try and use autogenerated ones * chore(wasm): Fix Cardano RTE wasm integration test module (#204) * fix(hermes): Update rust builders to the latest --------- Co-authored-by: bkioshn <35752733+bkioshn@users.noreply.github.com> Co-authored-by: Joaquín Rosales <joaquin.rosales@iohk.io> Co-authored-by: Felipe Rosa <felipe.rosa@iohk.io> Co-authored-by: Apisit Ritreungroj <38898766+apskhem@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add wasm test for
localtime
andclocks
modulesPlease confirm the following checks