-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sqlite): SQLite Module for Hermes #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add preliminary results from your benchmarks, comparing the speed of the in-memory sqlite db and the on-disk one?
Add a readme to the integration-test directory with a summary of the results of the benchmark. Make sure to include details of the machine it was run on. This way we have something to compare it to if we run it somewhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems it's time add a generalised object which will maintain wasmtime::Resources
.
So this abstraction will be used in both crypto
and sqllite
runtime extensions.
It could be something like:
trait ResourceAllocation {
fn allocate<T>(params: T) -> Self {
}
}
trait ResourceDeallocation {
fn deallocate<T>(params: T) -> Self {
}
}
struct ResourceManager<T> {
apps_state: DashMap<HermesAppName, DashMap<u32, wasmtime::Resources<T>>>,
}
Generalizing this is a great idea, but it might be a bit out of scope at the moment. Once the all the modules are stable, we can revisit the idea of creating traits and structs for internal generalization with a dedicated ticket. As we have state using in |
30b311b
to
55f7ac7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add integration test for Hermes SQLite module for running on WASM runner.
Related Issue(s)
Closes #246
Description of Changes
Please confirm the following checks