Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Hermes IPFS WASI WIT definitions #259

Merged
merged 19 commits into from
Jul 3, 2024
Merged

feat: Hermes IPFS WASI WIT definitions #259

merged 19 commits into from
Jul 3, 2024

Conversation

saibatizoku
Copy link
Contributor

@saibatizoku saibatizoku commented Jun 21, 2024 •
edited
Loading

Description

Implement WASI definitions for Hermes IPFS

Related Issue(s)

Closes #258

Description of Changes

Adds hermes:ipfs package to WASI definitions.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@saibatizoku saibatizoku added enhancement New feature or request review me PR is ready for review labels Jun 21, 2024
@saibatizoku saibatizoku self-assigned this Jun 21, 2024
@saibatizoku saibatizoku requested a review from a team June 21, 2024 02:05
@saibatizoku saibatizoku added the do not merge yet PR is not ready to be merged yet label Jun 21, 2024
@saibatizoku saibatizoku changed the base branch from feat/hermes-ipfs-crate to main June 21, 2024 04:51
stevenj
stevenj previously approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a first cut of a pub/sub API for hermes

@stevenj stevenj marked this pull request as draft June 27, 2024 10:39
Mr-Leshiy
Mr-Leshiy previously approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saibatizoku saibatizoku marked this pull request as ready for review July 2, 2024 13:43
@saibatizoku saibatizoku removed the do not merge yet PR is not ready to be merged yet label Jul 2, 2024
@saibatizoku saibatizoku linked an issue Jul 2, 2024 that may be closed by this pull request
🛠️ [TASK] : Define Hermes IPFS WASI WIT bindings #258
Closed
3 tasks
@saibatizoku saibatizoku enabled auto-merge (squash) July 2, 2024 13:52
@saibatizoku saibatizoku merged commit 8252c22 into main Jul 3, 2024
2 checks passed
@saibatizoku saibatizoku deleted the feat/hermes-ipfs-wasi branch July 3, 2024 13:00
apskhem pushed a commit that referenced this pull request Jul 10, 2024
@saibatizoku @stevenj @apskhem
feat: Hermes IPFS WASI WIT definitions (#259)
20727b1 
* feat(wit): Add bindings for hermes-ipfs

* feat(wit): add exports_hermes_ipfs_event_on_topic to stub-module.c

* feat(wip): add stubbed ipfs::api::Host implementation and on-topic event

* fix: update integration test modules

* feat: add ipfs runtime context

* fix: lints

* fix: update rust integration test modules

* chore: update project dictionary

* fix: pubsub-message includes topic

* fix: update IPFS WIT bindings

* fix: add errors and types, peer-evict function

* fix: typo

* chore: format code

* fix: add peer_evict method to Host implementation

* fix: remove unused import, update event.wit

---------

Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mr-Leshiy Mr-Leshiy Mr-Leshiy approved these changes

@FelipeRosa FelipeRosa Awaiting requested review from FelipeRosa

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@minikin minikin Awaiting requested review from minikin minikin is a code owner

@stevenj stevenj Awaiting requested review from stevenj stevenj is a code owner

Assignees

@saibatizoku saibatizoku

Labels
enhancement New feature or request review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
M3: Hermes Essential Modules
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Define Hermes IPFS WASI WIT bindings
3 participants
@saibatizoku @stevenj @Mr-Leshiy