Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Hermes IPFS runtime extension functionality #272

Merged
merged 61 commits into from
Jul 15, 2024
Merged

feat: Implement Hermes IPFS runtime extension functionality #272

merged 61 commits into from
Jul 15, 2024

Conversation

saibatizoku
Copy link
Contributor

@saibatizoku saibatizoku commented Jul 1, 2024 •
edited
Loading

Description

Implement Hermes IPFS runtime extension functionality

  • Updates hermes-ipfs crate
  • Updates WASI definitions
  • Implements thread-safe API and state for IPFS operations
  • Adds WASM module testing of IPFS
  • Fixes Earthly targets for Rust integration tests

Related Issue(s)

Closes #271

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@saibatizoku saibatizoku added enhancement New feature or request draft Draft labels Jul 1, 2024
@saibatizoku saibatizoku self-assigned this Jul 1, 2024
FelipeRosa
FelipeRosa reviewed Jul 11, 2024
View reviewed changes
Copy link

@FelipeRosa FelipeRosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple of comments but overall LGTM

hermes/bin/src/runtime_extensions/hermes/ipfs/state/api.rs Outdated Show resolved Hide resolved
hermes/bin/src/runtime_extensions/hermes/ipfs/state/mod.rs Outdated Show resolved Hide resolved
saibatizoku and others added 2 commits July 11, 2024 07:05
stevenj
stevenj approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me

@stevenj stevenj merged commit 9fa4890 into main Jul 15, 2024
36 checks passed
@stevenj stevenj deleted the feat/hermes-ipfs-rte branch July 15, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenj stevenj stevenj approved these changes

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

@minikin minikin Awaiting requested review from minikin minikin is a code owner

@apskhem apskhem Awaiting requested review from apskhem

@FelipeRosa FelipeRosa Awaiting requested review from FelipeRosa

@Mr-Leshiy Mr-Leshiy Awaiting requested review from Mr-Leshiy Mr-Leshiy is a code owner

Assignees

@saibatizoku saibatizoku

Labels
enhancement New feature or request review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
M3: Hermes Essential Modules
5 participants
@saibatizoku @stevenj @FelipeRosa @Mr-Leshiy @apskhem