-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Apply our Rust builder for wasm-preview-adapter
crates
#58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Mr-Leshiy
requested review from
stevenj,
FelipeRosa,
cong-or,
saibatizoku and
minikin
as code owners
January 12, 2024 14:01
Mr-Leshiy
force-pushed
the
feat/wasm-api
branch
from
January 18, 2024 12:01
02c201e
to
8b7181c
Compare
Mr-Leshiy
force-pushed
the
feat/wasm-api
branch
from
January 24, 2024 11:49
5183f61
to
af5f8c9
Compare
4 tasks
stevenj
requested changes
Jan 25, 2024
minikin
previously requested changes
Jan 25, 2024
* refactor(wasm): Refactor wasm component adapter and wasi/wit code * fix(wasm): Fix code format * fix(wasm): Update standard WASI .wit files to latest version * fix(wasm): Cleanup WASM wit definitions and remove things not compatible with Hermes. * fix(wasm): Fix code format * fix(spelling): Fix spelling check for wasm code * feat(spelling): Add target to help build words lists * fix(wasm): Fix code format * fix(wasm): Use relative path to wit files so we don;t need symlink * feat(wasm): Rewrite cron module and introduce basic hermes modules. Others need re-writing * fix(spelling): Fix spellcheck errors
stevenj
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
wasm-preview-adapter
crate.clippy
lintsRelated Issue(s)
Part of #20
Description of Changes
Related Pull Requests
input-output-hk/catalyst-ci#140