[EC-310] Implement EIP-684 #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtkaczyk
force-pushed
the
feature/eip684
branch
from
d45358f
to
53ef726
Compare
There was a problem hiding this comment.
Code looks good but it seems that encoding of VMTests changed and they are now failing with io.circe.DecodingFailure$$anon$1: [A]List[A]: DownField(logs),DownField(log4_nonEmptyMem)
Do you think it will be easy enough to fix it in this pr or it would require another task?
KonradStaniec
approved these changes
Oct 20, 2017
LukasGasior1
approved these changes
Oct 23, 2017
| /** | ||
| * According to EIP161: An account is considered empty when it has no code and zero nonce and zero balance. | ||
| * An account's storage is not relevant when determining emptiness. | ||
| */ | ||
| def isEmpty: Boolean = | ||
| nonce == UInt256.Zero && balance == UInt256.Zero && codeHash == Account.EmptyCodeHash | ||
| def isEmpty(startNonce: UInt256 = UInt256.Zero): Boolean = |
There was a problem hiding this comment.
what do you think about removing the default here? it seems to make sense to force someone using this method to always pass this param
There was a problem hiding this comment.
Why do you think so? I think that if Account#empty has a default argument, then logically it follow to add the default here. (And I think the defaults stem from the fact the idea of non-zero starting is considered funny ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP-684
This also enables us to run all the ETS
BlockchainSuitetests (except for metropolis fork).The ETS test files have been updated (latest commit: 2017-10-18)