Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Prometheus metrics for signer #1990

Closed
5 tasks done
Tracked by #1481 ...
jpraynaud opened this issue Oct 9, 2024 · 0 comments · Fixed by #1998
Closed
5 tasks done
Tracked by #1481 ...

Refactor Prometheus metrics for signer #1990

jpraynaud opened this issue Oct 9, 2024 · 0 comments · Fixed by #1998
Assignees
Labels
refactoring 🛠️ Code refactoring and enhancements

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Oct 9, 2024

Why

We want to simplify the code of the metrics module in the signer: avoid repeating code for declaration of the metrics, provide a unique entry point for updating a metric and make the server available for other nodes.

What

Refactor the metrics module in the signer.

How

  • Create a macro to generate the service with described metrics
  • Create a MetricCollector on which we can update or fetch the metric
  • Create a new internal/mithril-metrics crate:
    • Make some tooling for declaration of new metrics
    • Migrate the metrics server (which will use a MetricsServiceExporter trait as a dependency)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring 🛠️ Code refactoring and enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants