Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite compatibility in aggregator #837

Closed
jpraynaud opened this issue Mar 30, 2023 · 1 comment
Closed

SQLite compatibility in aggregator #837

jpraynaud opened this issue Mar 30, 2023 · 1 comment
Assignees
Labels
bug ⚠️ Something isn't working D-medium Difficulty: medium refactoring 🛠️ Code refactoring and enhancements

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Mar 30, 2023

Issue

We have noticed that the Github Action runners don't have the minimum expected SQLite version:

  • We need version 3.40+ for running the queries for the monitoring on the aggregator
  • We need version 3.37+ for everything else in the aggregator
  • We have also noticed that the packages that we use to install the version 3.40.1 in the mithril-infra has a new location suffixed with 3.40.1-2 when it used to be 3.40.1-1

To do

We need to:

  • find a solution that is compatible with the CI (on Linux, Mac OS and Windows) that provides fast enough install time on all the CI runners
  • probably implement the same install on the infrastructure
  • create a tool sub-command for exporting monitoring data?
  • create a tool sub-command for compacting the database?

Dependencies

Should be done once the tasks Separate data disk from VM system disk of #767 is completed

@jpraynaud jpraynaud added D-medium Difficulty: medium refactoring 🛠️ Code refactoring and enhancements labels Mar 30, 2023
@jpraynaud jpraynaud changed the title SQLite compatibility issue in aggregator SQLite compatibility in aggregator Mar 30, 2023
@Alenar Alenar mentioned this issue Jun 29, 2023
11 tasks
@Alenar
Copy link
Collaborator

Alenar commented Jun 30, 2023

With PR #1024 sqlite is now bundled with our binaries, meaning that we don't need it to be installed on the system anymore and that we can use the latest sqlite version (right now 3.42.0).

This address most of the issues of this ticket.

Todo:

  • Survey that the bundled sqlite works as intended (ie: do a install on a system/docker without sqlite and check that our nodes works)
  • Update doc websites to remove the install of sqlite as a dependency to install our nodes
  • Update dockerfiles to remove sqlite installation (only for "ci" dockerfiles, the other are used in dev so having the sqlite bin available is usefull for debug purpose).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ⚠️ Something isn't working D-medium Difficulty: medium refactoring 🛠️ Code refactoring and enhancements
Projects
None yet
Development

No branches or pull requests

2 participants