Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove certificate hash from Artifact #932

Closed
5 tasks done
jpraynaud opened this issue May 22, 2023 · 0 comments · Fixed by #1027
Closed
5 tasks done

Remove certificate hash from Artifact #932

jpraynaud opened this issue May 22, 2023 · 0 comments · Fixed by #1027
Labels
D-medium Difficulty: medium mainnet-protocol 🚀 Protocol for mainnet optimization 🛠️ Optimization and/or small enhancements refactoring 🛠️ Code refactoring and enhancements task

Comments

@jpraynaud
Copy link
Member

jpraynaud commented May 22, 2023 •
edited
Loading

Issue

Remove the certificate hash from the:

  • Snapshot artifact entity
  • Mithril Stake Distribution artifact entity

To do

  • Remove certificate_hash in Snapshot entity
  • Remove certificate_hash in Mithril Stake Distribution entity
  • Create migration to remove certificate_hash from signed_entity table
  • Split Message Adapter in From Message Adapter (without type constraint) and To Message Adapter (with type constraint Serialize/DeSerialize)
  • Implement the correct Message Adapter trait for all the adapters in all the nodes
@jpraynaud jpraynaud added task refactoring 🛠️ Code refactoring and enhancements dev 💪 D-medium Difficulty: medium mainnet-protocol 🚀 Protocol for mainnet labels May 22, 2023
@jpraynaud jpraynaud added the optimization 🛠️ Optimization and/or small enhancements label Jun 1, 2023
@jpraynaud jpraynaud changed the title Remove certificate hash from Snapshot Remove certificate hash from Artifact Jun 16, 2023
@jpraynaud jpraynaud added good first issue 👋 Good for newcomers and removed good first issue 👋 Good for newcomers labels Jun 16, 2023
@dlachaume dlachaume mentioned this issue Jul 3, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D-medium Difficulty: medium mainnet-protocol 🚀 Protocol for mainnet optimization 🛠️ Optimization and/or small enhancements refactoring 🛠️ Code refactoring and enhancements task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove certificate hash from Artifact dlachaume/mithril
1 participant
@jpraynaud