Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On chain root peers #2535

Closed
coot opened this issue Aug 24, 2020 · 3 comments · Fixed by #2536
Closed

On chain root peers #2535

coot opened this issue Aug 24, 2020 · 3 comments · Fixed by #2536
Assignees
@karknu
Milestone
S21 2020-09-15

Comments

@coot
Copy link
Contributor

coot commented Aug 24, 2020

The peer governor needs to sample peers from the pools registered on the chain. We would like to sample them according to stake distribution.

The governor has a method for getting root peers (using IO) which we can construct provided a list of DomainAddress ~ (DNS, PortNumber). Giving us something like m [DomainAddress] should work just fine.

The governor asks for root peers with an exponential backoff in case of failures, ensuring that it is not done too often.
@coot coot added the consensus issues related to ouroboros-consensus label Aug 24, 2020
@mrBliss mrBliss added this to the S20 2020-08-27 milestone Aug 24, 2020
mrBliss added a commit that referenced this issue Aug 24, 2020
@mrBliss
LedgerSupportsPeerSelection: return peers registered in ledger state
5e96201 
Fixes #2535.

For Shelley, this returns the stake pool relays ordered by descending stake.
@mrBliss mrBliss mentioned this issue Aug 24, 2020
Merged
@mrBliss mrBliss linked a pull request Aug 24, 2020 that will close this issue
LedgerSupportsPeerSelection: return peers registered in ledger state #2536
Merged
mrBliss added a commit that referenced this issue Aug 25, 2020
@mrBliss
LedgerSupportsPeerSelection: return peers registered in ledger state
602c946 
Fixes #2535.

For Shelley, this returns the stake pool relays ordered by descending stake.
@mrBliss mrBliss modified the milestones: S20 2020-08-27, S21 2020-09-10 Sep 1, 2020
mrBliss added a commit that referenced this issue Sep 8, 2020
@mrBliss
LedgerSupportsPeerSelection: return peers registered in ledger state
225a16e 
Fixes #2535.

For Shelley, this returns the stake pool relays ordered by descending stake.
mrBliss added a commit that referenced this issue Sep 29, 2020
@mrBliss
LedgerSupportsPeerSelection: return peers registered in ledger state
0e6b061 
Fixes #2535.
mrBliss added a commit that referenced this issue Nov 11, 2020
@mrBliss
LedgerSupportsPeerSelection: return peers registered in ledger state
c8fb01c 
Fixes #2535.
mrBliss added a commit that referenced this issue Nov 20, 2020
@mrBliss
LedgerSupportsPeerSelection: return peers registered in ledger state
57586b0 
Fixes #2535.
karknu pushed a commit that referenced this issue Nov 20, 2020
@mrBliss @karknu
LedgerSupportsPeerSelection: return peers registered in ledger state
1426103 
Fixes #2535.
karknu pushed a commit that referenced this issue Dec 8, 2020
@mrBliss @karknu
LedgerSupportsPeerSelection: return peers registered in ledger state
fa6c4fc 
Fixes #2535.
mrBliss added a commit that referenced this issue Dec 9, 2020
@mrBliss
LedgerSupportsPeerSelection: return peers registered in ledger state
8f9e779 
Fixes #2535.
mrBliss added a commit that referenced this issue Dec 10, 2020
@mrBliss
LedgerSupportsPeerSelection: return peers registered in ledger state
2057109 
Fixes #2535.
iohk-bors bot added a commit that referenced this issue Dec 10, 2020
@iohk-bors @mrBliss @karknu
Merge #2536
02771ee 
2536: LedgerSupportsPeerSelection: return peers registered in ledger state r=mrBliss a=mrBliss

Fixes #2535.

For Shelley, this returns the stake pool relays ordered by descending stake.

Co-authored-by: Thomas Winant <thomas@well-typed.com>
Co-authored-by: Karl Knutsson <karl.knutsson@iohk.io>
@iohk-bors iohk-bors bot closed this as completed in 2e771ab Dec 10, 2020
@karknu karknu reopened this Dec 10, 2020
@karknu
Copy link
Contributor

karknu commented Dec 10, 2020

This issue isn't done yet.

karknu pushed a commit that referenced this issue Dec 15, 2020
@mrBliss @karknu
LedgerSupportsPeerSelection: return peers registered in ledger state
ed0b373 
Fixes #2535.
coot pushed a commit that referenced this issue Dec 18, 2020
@mrBliss @coot
LedgerSupportsPeerSelection: return peers registered in ledger state
f0a159e 
Fixes #2535.
coot pushed a commit that referenced this issue Dec 18, 2020
@mrBliss @coot
LedgerSupportsPeerSelection: return peers registered in ledger state
2606905 
Fixes #2535.
coot pushed a commit that referenced this issue Dec 18, 2020
@mrBliss @coot
LedgerSupportsPeerSelection: return peers registered in ledger state
90b9da9 
Fixes #2535.
@mrBliss mrBliss removed their assignment Jan 7, 2021
@mrBliss mrBliss removed the consensus issues related to ouroboros-consensus label Jan 7, 2021
@mrBliss
Copy link
Contributor

mrBliss commented Jan 7, 2021

The consensus-side of this has been done in #2536, removing the consensus label now.

@karknu
Copy link
Contributor

karknu commented Jan 12, 2022

This is done.

@karknu karknu closed this as completed Jan 12, 2022
@karknu karknu moved this to Done in Ouroboros Network Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karknu karknu

Labels
None yet
Projects
None yet
Milestone
S21 2020-09-15
Development

Successfully merging a pull request may close this issue.

LedgerSupportsPeerSelection: return peers registered in ledger state IntersectMBO/ouroboros-network
3 participants
@mrBliss @coot @karknu