Improve mux tracing #2794
Merged
Improve mux tracing #2794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mux is not dying when a mini-protocol terminates. Let's reflect that in the trace.
Sometimes the parameters blend together, it's nicer to put some brackets around them.
Error if `putTMVar completionVar` blocks. If there ever will be a mistake, it will be clearer than a deadlock.
coot
force-pushed
the
coot/network-mux-tracing
branch
from
1c0921f
to
fca244a
Compare
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 8, 2020
2794: Improve mux tracing r=coot a=coot This PR consist of three patches, the last one is not at all about tracing: - network-mux: replaced 'Dying' with MuxTraceTerminating Mux is not dying anymore when a mini-protocol terminates, let's reflect that in the trace. - network-mux: sligtly nicer Show instance for MuxTrace - network-mux: filling completionVar should never block ~Might be **controverial**!~ It is sensible to throw an exception if it blocks. Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
|
Build failed: |
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 8, 2020
2794: Improve mux tracing r=coot a=coot This PR consist of three patches, the last one is not at all about tracing: - network-mux: replaced 'Dying' with MuxTraceTerminating Mux is not dying anymore when a mini-protocol terminates, let's reflect that in the trace. - network-mux: sligtly nicer Show instance for MuxTrace - network-mux: filling completionVar should never block ~Might be **controverial**!~ It is sensible to throw an exception if it blocks. Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
|
Build failed: |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consist of three patches, the last one is not at all about tracing:
Mux is not dying anymore when a mini-protocol terminates, let's reflect that
in the trace.
Might be controverial!It is sensible to throw an exception if it blocks.