Allow to acquire tip by LocalStateQuery protocol client. #2875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`IO a` is a monoid (semigroup) whenever `a` is a monoid (semigroup). This patch provides similar instance for `IOSim`.
QuickCheck property which checks that two codecs are compatible. Encoding a message with one of them and decoding it with the other one yields the original message.
coot
added
consensus
coot
force-pushed
the
coot/local-state-query
branch
from
6ccc61b
to
0379993
Compare
dcoutts
approved these changes
Jan 15, 2021
ouroboros-network/protocol-tests/Ouroboros/Network/Protocol/LocalStateQuery/Test.hs
Show resolved
Hide resolved
ouroboros-consensus/src/Ouroboros/Consensus/MiniProtocol/LocalStateQuery/Server.hs
Show resolved
Hide resolved
ouroboros-network/src/Ouroboros/Network/Protocol/LocalStateQuery/Codec.hs
Outdated
Show resolved
Hide resolved
coot
force-pushed
the
coot/local-state-query
branch
from
0984bd2
to
64ede0f
Compare
|
^ this is solved. |
coot
force-pushed
the
coot/local-state-query
branch
from
64ede0f
to
6039aae
Compare
|
bors merge |
nfrisby
reviewed
Jan 18, 2021
ouroboros-network/src/Ouroboros/Network/Protocol/LocalStateQuery/Codec.hs
Show resolved
Hide resolved
|
Build succeeded: |
nfrisby
reviewed
Jan 18, 2021
| @@ -140,16 +143,19 @@ checkOutcome k chain = conjoin . map (uncurry checkResult) | |||
| (property False) | |||
| | otherwise | |||
| -> tabulate "Acquired" ["AcquireFailurePointTooOld"] $ property True | |||
| checkResult Nothing = \case | |||
| Right _result -> tabulate "Acquired" ["Success"] True | |||
| Left failure -> counterexample ("acuire tip point resulted in " ++ show failure) False | |||
There was a problem hiding this comment.
I'll fix this in another pr.
nfrisby
reviewed
Jan 18, 2021
| @@ -1,5 +1,6 @@ | |||
| {-# LANGUAGE NamedFieldPuns #-} | |||
| {-# LANGUAGE ScopedTypeVariables #-} | |||
| {-# LANGUAGE TupleSections #-} | |||
There was a problem hiding this comment.
I'll fix this in another pr.
coot
added a commit
that referenced
this pull request
May 16, 2022
2875: Allow to acquire tip by LocalStateQuery protocol client. r=coot a=coot * Change mini-protocol description * Redefine codec, add a test which ensures that the new version of the codec is compatible with the previous one. * Updated consensus, including the server. * Added new supported version in `ouroboros-consensus-cardano` As a bonus: * `instance Monoid a => Monoid (IOSim s a)` Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ouroboros-consensus-cardanoAs a bonus:
instance Monoid a => Monoid (IOSim s a)