Review changes for #2911 #2921
Merged
Review changes for #2911 #2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coot
commented
Feb 3, 2021
coot
commented
- network-mux: miniProtocolStateMap
- StructLinger: added todo
Do not expose underlying TVar's.
karknu
reviewed
Feb 3, 2021
| @@ -14,6 +14,7 @@ import Network.Socket (Socket) | |||
| import qualified Network.Socket as Socket | |||
|
|
|||
|
|
|||
| -- TODO: tobe removed once a new version of `network` library is released. | |||
We can remove it once new version of network library is released; haskell/network#491 is merged by now.
We will not need it.
coot
force-pushed
the
coot/review-changes
branch
from
41d8cd5
to
8a33e61
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.