Tracing improvements #2924
Merged
Tracing improvements #2924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coot
commented
Feb 4, 2021
coot
commented
- mini-protocols: trace termination message
- tx-submission-inbound: improved logging
coot
added
chain-sync
networking
tx-submission
karknu
approved these changes
Feb 5, 2021
| @@ -39,8 +40,7 @@ directPipelined (TxSubmissionServerPipelined mserver) | |||
| SendMsgReplyTxIds (BlockingReply txids) client' -> do | |||
| server' <- serverNext txids | |||
| directSender q server' client' | |||
| SendMsgDone b -> | |||
| return (a, b) | |||
| SendMsgDone b -> (,b) <$> a | |||
There was a problem hiding this comment.
Is this change really needed?
There was a problem hiding this comment.
Yes, because a :: m a, while it used to be a :: a; using monadic action allows to log a message when sending MsgDone.
|
bors merge |
|
Build succeeded: |
coot
added a commit
that referenced
this pull request
May 16, 2022
2876: DNS subscription refactor for A/AAAA lookup r=coot a=Infinisil While looking into that code I noticed that I could be improved a bit. This includes: - Removing the need for any extra `TMVar`'s and `TVar`'s - Previously only exceptions for the first thread to finish were caught and logged. Now exceptions for both threads are caught - Simplify the code for more readability Other than all thread exceptions now being caught, this is only a refactoring without any functional change. To convince myself of the correctness of this change, I split the changes into smallish commits, which should relatively easily be verifiable for equivalence. 2924: Tracing improvements r=coot a=coot - mini-protocols: trace termination message - tx-submission-inbound: improved logging Co-authored-by: Silvan Mosberger <contact@infinisil.com> Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.