Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some links to mini-protocol code in documentation #3089

Merged
merged 2 commits into from
May 10, 2021
Merged

Fix some links to mini-protocol code in documentation #3089

merged 2 commits into from
May 10, 2021

Conversation

kantp
Copy link
Contributor

@kantp kantp commented Apr 26, 2021

A few of the links from the documentation to the code of mini protocols broke
during refactoring.

Fix some links to mini-protocol code in documentation
a57124e 
A few of the links from the documentation to the code of mini protocols broke
during refactoring.
@kantp kantp requested a review from coot April 26, 2021 10:17
@kantp kantp requested review from karknu and njd42 as code owners April 26, 2021 10:17
@coot
Copy link
Contributor

coot commented Apr 26, 2021 •
edited
Loading

@kantp it's fixed in #3088. I also replaced links to the code with links to haddock (\hsref was replaced with \haddockref).

Maybe the problem is that the link itself. CI builds on every branch, and I suspect that the link in our README, points to the latest build, which might not be the latest version merged to master.

coot
coot approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I resolved conflicts; one missing link found 🎯

@coot
Copy link
Contributor

coot commented May 10, 2021

bors merge

@coot
Copy link
Contributor

coot commented May 10, 2021

bors cancel

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 10, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 7c8fac8 into master May 10, 2021
@iohk-bors iohk-bors bot deleted the kantp/fix-links branch May 10, 2021 10:22
coot added a commit that referenced this pull request May 16, 2022
@iohk-bors @coot
Merge #3089
093f8fe 
3089: Fix some links to mini-protocol code in documentation r=coot a=kantp

A few of the links from the documentation to the code of mini protocols broke
during refactoring.

Co-authored-by: Philipp Kant <philipp.kant@iohk.io>
Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njd42 njd42 njd42 approved these changes

@coot coot coot approved these changes

@karknu karknu Awaiting requested review from karknu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kantp @coot @njd42