Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace peer for chainsync clients #3091

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Conversation

karknu
Copy link
Contributor

@karknu karknu commented Apr 26, 2021

This makes it possible to track which peer presented us which header at what time. Useful for debugging/performance analysis.

@karknu karknu requested a review from nfrisby as a code owner April 26, 2021 12:17
Copy link
Contributor

@nfrisby nfrisby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Happy to see this addition. Thanks!

@nfrisby
Copy link
Contributor

nfrisby commented Apr 26, 2021

Here are some pointers about how to deal with the stylish-haskell objection reported in the buildkite CI.

https://github.com/input-output-hk/ouroboros-network/#formatting

@karknu karknu force-pushed the karknu/chainsync_trace_peer branch from d33c6b4 to 76351fb Compare April 26, 2021 13:51
@karknu
Copy link
Contributor Author

karknu commented Apr 26, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 26, 2021

@iohk-bors iohk-bors bot merged commit e39bfc4 into master Apr 26, 2021
@iohk-bors iohk-bors bot deleted the karknu/chainsync_trace_peer branch April 26, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants