Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAD-2907 blockfetch client: add SendFetchRequest msg to TraceFetchClientState #3190

Merged
merged 1 commit into from
May 28, 2021

Conversation

deepfire
Copy link
Contributor

A message to mark the point when a fragment request is actually sent to the peer.

@deepfire deepfire requested review from coot and karknu as code owners May 27, 2021 14:55
@deepfire deepfire requested review from dcoutts and nfrisby May 27, 2021 19:56
Copy link
Contributor

@nfrisby nfrisby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not Approving only because this isn't my jurisdiction. I made a comment, very minor.

…entState

A message to mark the point when a fragment request is actually sent to the peer.
@deepfire deepfire force-pushed the cad-2907-send-fetch-request branch from 6a1da69 to 9812147 Compare May 27, 2021 23:40
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepfire
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 28, 2021

@iohk-bors iohk-bors bot merged commit 42cd78a into master May 28, 2021
@iohk-bors iohk-bors bot deleted the cad-2907-send-fetch-request branch May 28, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants