-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for V7 keepalive #3193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3187. |
tested successfully on alonzo-blue. |
coot
requested changes
Jun 2, 2021
coot
approved these changes
Jun 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
NodeToNode version 7 fixed the cbor encoding for the keepalive miniprotocol.
karknu
force-pushed
the
karknu/cardano-ping-v7
branch
from
June 2, 2021 09:06
f7d21bb
to
0cdf28f
Compare
bors r+ |
Build succeeded: |
jbgi
added a commit
to input-output-hk/cardano-ops
that referenced
this pull request
Jun 3, 2021
jbgi
added a commit
to input-output-hk/cardano-ops
that referenced
this pull request
Jul 13, 2021
jbgi
added a commit
to input-output-hk/cardano-ops
that referenced
this pull request
Jul 19, 2021
jbgi
added a commit
to input-output-hk/cardano-ops
that referenced
this pull request
Aug 5, 2021
jbgi
added a commit
to input-output-hk/cardano-ops
that referenced
this pull request
Aug 6, 2021
jbgi
added a commit
to input-output-hk/cardano-ops
that referenced
this pull request
Aug 10, 2021
jbgi
added a commit
to input-output-hk/cardano-ops
that referenced
this pull request
Aug 12, 2021
jbgi
added a commit
to input-output-hk/cardano-ops
that referenced
this pull request
Aug 13, 2021
coot
pushed a commit
that referenced
this pull request
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeToNode version 7 fixed the cbor encoding for the keepalive
miniprotocol.