Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io-sim-classes: missing api #3196

Merged
merged 3 commits into from
Jun 1, 2021
Merged

io-sim-classes: missing api #3196

merged 3 commits into from
Jun 1, 2021

Conversation

coot
Copy link
Contributor

@coot coot commented Jun 1, 2021

Fixes issue #3189.

  • io-sim-classes: newTBQueueIO for IO and ReaderT instances
  • io-sim-classes: added missing api

@coot
io-sim-classes: newTBQueueIO for IO and ReaderT instances
3624ab1 
Either use the one provided by `stm` package (IO) or lift the one from base monad
instance (ReaderT).
@coot coot added io-classes Issues / PRs related to io-classes networking labels Jun 1, 2021
@coot coot requested review from bolt12, dcoutts and karknu June 1, 2021 07:08
dcoutts
dcoutts approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bolt12
bolt12 approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@bolt12 bolt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! CI is not building though!

@coot
io-sim-classes: added missing api
bc91beb 
* swapTVar
* readTVarIO
* newTQueueIO

both MonadSTM and MonadSTM.Strict modules are updated.
@coot coot force-pushed the coot/monad-stm-missing-api branch from 4f90e2d to bc91beb Compare June 1, 2021 09:43
@coot coot requested a review from nfrisby as a code owner June 1, 2021 10:29
@coot
Copy link
Contributor Author

coot commented Jun 1, 2021

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 1, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit ba06289 into master Jun 1, 2021
@iohk-bors iohk-bors bot deleted the coot/monad-stm-missing-api branch June 1, 2021 14:35
coot added a commit that referenced this pull request May 16, 2022
@iohk-bors @coot
Merge #3196
6bdf533 
3196: io-sim-classes: missing api r=coot a=coot

Fixes issue #3189.

- io-sim-classes: newTBQueueIO for IO and ReaderT instances
- io-sim-classes: added missing api


Co-authored-by: Marcin Szamotulski <profunctor@pm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolt12 bolt12 bolt12 approved these changes

@dcoutts dcoutts dcoutts approved these changes

@karknu karknu Awaiting requested review from karknu

@nfrisby nfrisby Awaiting requested review from nfrisby

Assignees
No one assigned
Labels
io-classes Issues / PRs related to io-classes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coot @dcoutts @bolt12